Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pack and install: should be able to use the d.ts failed #1474

Closed
flaky-bot bot opened this issue Oct 11, 2022 · 3 comments
Closed

pack and install: should be able to use the d.ts failed #1474

flaky-bot bot opened this issue Oct 11, 2022 · 3 comments
Assignees
Labels
flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Oct 11, 2022

This test failed!

To configure my behavior, see the Flaky Bot documentation.

If I'm commenting on this issue too often, add the flakybot: quiet label and
I will stop commenting.


commit: 4bbd13f
buildURL: Build Status, Sponge
status: failed

Test output
Command failed with exit code 1: npm install
Error: Command failed with exit code 1: npm install
    at makeError (node_modules/execa/lib/error.js:60:11)
    at handlePromise (node_modules/execa/index.js:118:26)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async packAndInstall (build/system-test/test.kitchen.js:41:5)
        -> /workspace/system-test/test.kitchen.ts:42:3
    at async Context. (build/system-test/test.kitchen.js:53:9)
        -> /workspace/system-test/test.kitchen.ts:55:5
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 11, 2022
@sofisl
Copy link
Contributor

sofisl commented Oct 13, 2022

See also: googleapis/nodejs-googleapis-common#489

@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Oct 17, 2022
@flaky-bot
Copy link
Author

flaky-bot bot commented Oct 17, 2022

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


When run at the same commit (4bbd13f), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@danielbankhead
Copy link
Member

Looks fine now: #1476

Definitely a transient dependency issue. Next time this happens we should capture the root issue by running the system-test locally (gaxios seems to have non-side effect system-tests, see googleapis/gaxios#506 & googleapis/gaxios#507). This way we can determine how to make this less flaky in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants