Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: IdTokenClient expiry_date check #1555

Merged
merged 2 commits into from Jun 6, 2023
Merged

fix: IdTokenClient expiry_date check #1555

merged 2 commits into from Jun 6, 2023

Conversation

AyushWalekar
Copy link
Contributor

@AyushWalekar AyushWalekar commented May 25, 2023 •
edited

to respect eagerRefreshThresholdMillis of parent class OAuth2Client

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1554 馃

@AyushWalekar
fix: IdTokenClient expiry_date check
d095821 
to respect eagerRefreshThresholdMillis of parent class `OAuth2Client`
@AyushWalekar AyushWalekar requested review from a team as code owners May 25, 2023 06:49
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 25, 2023
@danielbankhead danielbankhead added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 6, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 6, 2023
@danielbankhead danielbankhead merged commit efcdef1 into googleapis:main Jun 6, 2023
14 checks passed
@release-please release-please bot mentioned this pull request Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbankhead danielbankhead danielbankhead approved these changes

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

auth/IdTokenClient should respect eagerRefreshThresholdMillis while checking token expiry
3 participants
@AyushWalekar @danielbankhead @yoshi-kokoro