Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IdentityPoolClient for url-sourced subject tokens getAccessToken(): should reject with retrieveSubjectToken error failed #1579

Closed
flaky-bot bot opened this issue Jun 24, 2023 · 4 comments
Assignees
Labels
flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Jun 24, 2023

Note: #1291 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.


commit: 070ec96
buildURL: Build Status, Sponge
status: failed

Test output
Expected values to be strictly deep-equal:
+ actual - expected
  • Comparison {}
  • Comparison {
  • code: '404'
  • }
    AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
  • actual - expected

  • Comparison {}

  • Comparison {
  • code: '404'
  • }
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async Context. (build/test/test.identitypoolclient.js:818:17)
    -> /workspace/test/test.identitypoolclient.ts:1037:9
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. labels Jun 24, 2023
@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 26, 2023

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


When run at the same commit (070ec96), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@danielbankhead danielbankhead added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jul 7, 2023
@danielbankhead danielbankhead self-assigned this Jul 7, 2023
@danielbankhead
Copy link
Member

Fix: #1589

@flaky-bot flaky-bot bot reopened this Jul 20, 2023
@flaky-bot
Copy link
Author

flaky-bot bot commented Jul 20, 2023

Oops! Looks like this issue is still flaky. It failed again. 😬

I reopened the issue, but a human will need to close it again.


commit: d8e5eb9
buildURL: Build Status, Sponge
status: failed

Test output
Expected values to be strictly deep-equal:
+ actual - expected
  • Comparison {}
  • Comparison {
  • status: 404
  • }
    AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
  • actual - expected

  • Comparison {}

  • Comparison {
  • status: 404
  • }
    at runMicrotasks ()
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at Context. (test/test.identitypoolclient.ts:1035:9)

@danielbankhead danielbankhead added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 31, 2023
@danielbankhead
Copy link
Member

Closing in order to get fresher error logs (the error message here are not in the logs for some reason)

@danielbankhead danielbankhead closed this as not planned Won't fix, can't repro, duplicate, stale Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

1 participant