feat: Expose Compute's Service Account Email #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeitzman
reviewed
Oct 2, 2023
| @@ -33,7 +33,7 @@ export interface ComputeOptions extends RefreshOptions { | |||
| } | |||
|
|
|||
| export class Compute extends OAuth2Client { | |||
| private serviceAccountEmail: string; | |||
There was a problem hiding this comment.
nit: readonly maybe? Looks like the java implementation has a getter but no setter
aeitzman
approved these changes
Oct 2, 2023
danielbankhead
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns with the Java library:
https://github.com/googleapis/google-auth-library-java/blob/64eed74479944dd596b4228c8324ee3dd3431789/oauth2_http/java/com/google/auth/oauth2/ComputeEngineCredentials.java#L473-L483
Fixes #1386 馃