feat: Enable Retries For Auth Requests #1791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddelgrosso1
approved these changes
Apr 10, 2024
aeitzman
reviewed
Apr 11, 2024
| */ | ||
| protected async refreshToken( | ||
| refreshToken?: string | null |
There was a problem hiding this comment.
Is this a breaking change?
There was a problem hiding this comment.
Technically, yes, however since its introduction a few years ago I think this would cause more confusion for customers rather than cleaning it up:
I included this change in the current PR as it was causing a lint issue.
| @@ -401,12 +401,12 @@ describe('AwsClient', () => { | |||
| // Simulate error during region retrieval. | |||
| const scope = nock(metadataBaseUrl) | |||
| .get('/latest/meta-data/placement/availability-zone') | |||
| .reply(500); | |||
| .reply(400); | |||
There was a problem hiding this comment.
Why were the status codes here all changed?
There was a problem hiding this comment.
Technically 500s are retryable and tests would fail with an unexpected error. As the tests want a error on the first call, I changed it to 400.
aeitzman
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1366
Fixes #1779
Fixes #1780
Fixes #1785
Provides relief for:
Related:
Follow-up:
馃