-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose a few httplib2 properties and a method #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaoliugg
approved these changes
Jul 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
craigcitro
added a commit
to craigcitro/google-auth-library-python-httplib2
that referenced
this pull request
Jul 21, 2020
Similar to googleapis#9, this exposes the `redirect_codes` attribute of the underlying httplib2.Http instance on AuthorizedHttp, letting users modify the set of HTTP status codes interpreted as redirects (as in googleapis/google-api-python-client#803).
busunkim96
pushed a commit
that referenced
this pull request
Jul 25, 2020
Similar to #9, this exposes the `redirect_codes` attribute of the underlying httplib2.Http instance on AuthorizedHttp, letting users modify the set of HTTP status codes interpreted as redirects (as in googleapis/google-api-python-client#803).
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 1, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [0.1.0](https://www.github.com/googleapis/google-auth-library-python-httplib2/compare/v0.0.3...v0.1.0) (2021-03-01) ### Features * add close method ([#14](https://www.github.com/googleapis/google-auth-library-python-httplib2/issues/14)) ([feda187](https://www.github.com/googleapis/google-auth-library-python-httplib2/commit/feda187133beeb656fdd7f30ed124ed1e428a74a)) * expose a few httplib2 properties and a method ([#9](https://www.github.com/googleapis/google-auth-library-python-httplib2/issues/9)) ([e3aa44e](https://www.github.com/googleapis/google-auth-library-python-httplib2/commit/e3aa44e01e2987989671467c7a022ea33829eb2f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expose a few httplib2 properties and a method to help gcloud migration from httplib2 to google-auth-httplib2
Linter seems to have some problem, so I have to disable 2 rules:
(1) useless-object-inheritance: linter doesn't like class to inherits object in
class AuthorizedHttp(object)
(2) wrong-import-order: linter complains wrong import order, but it contradicts itself, for instance,
and after changing it:
However, original order doesn't seem to be wrong.