Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose a few httplib2 properties and a method #9

Merged
merged 7 commits into from
Jul 7, 2020

Conversation

arithmetic1728
Copy link
Contributor

@arithmetic1728 arithmetic1728 commented Jul 1, 2020

expose a few httplib2 properties and a method to help gcloud migration from httplib2 to google-auth-httplib2

Linter seems to have some problem, so I have to disable 2 rules:
(1) useless-object-inheritance: linter doesn't like class to inherits object in class AuthorizedHttp(object)
(2) wrong-import-order: linter complains wrong import order, but it contradicts itself, for instance,

tests/test_google_auth_httplib2.py:18:0: C0411: third party import 
"from six.moves import http_client" should be placed before "import mock" (wrong-import-order)

and after changing it:

tests/test_google_auth_httplib2.py:18:1: I100 Import statements are in the wrong order.
 'import mock' should be before 'from six.moves import http_client'

However, original order doesn't seem to be wrong.

@arithmetic1728 arithmetic1728 marked this pull request as ready for review July 1, 2020 21:46
Copy link

@yaoliugg yaoliugg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@busunkim96 busunkim96 merged commit e3aa44e into googleapis:master Jul 7, 2020
craigcitro added a commit to craigcitro/google-auth-library-python-httplib2 that referenced this pull request Jul 21, 2020
Similar to googleapis#9, this exposes the `redirect_codes` attribute of the underlying
httplib2.Http instance on AuthorizedHttp, letting users modify the set of HTTP
status codes interpreted as redirects (as in
googleapis/google-api-python-client#803).
busunkim96 pushed a commit that referenced this pull request Jul 25, 2020
Similar to #9, this exposes the `redirect_codes` attribute of the underlying
httplib2.Http instance on AuthorizedHttp, letting users modify the set of HTTP
status codes interpreted as redirects (as in
googleapis/google-api-python-client#803).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants