fix: Fix IDTokenCredentials update bug #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbmccoy
requested review from
arithmetic1728,
sai-sunder-s,
TimurSadykov and
a team
as code owners
arithmetic1728
changed the title
|
@mbmccoy could you change the commit message to "fix: Fix IDTokenCredentials update bug" (with a "fix:" prefix) so it can pass the commit message format check? Also could you add a simple unit test for this change? |
The `from_credentials` method should use the specified `target_credentials`.
|
Thanks @mbmccoy. I have updated your commit to match our conventional commits style guide. |
|
@sai-sunder-s can you take a look as well? |
clundin25
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
clundin25
added
the
kokoro:run
clundin25
approved these changes
Aug 2, 2022
yoshi-kokoro
removed
the
kokoro:run
sai-sunder-s
reviewed
Aug 2, 2022
| @@ -473,6 +473,7 @@ def test_id_token_from_credential( | |||
|
|
|||
| assert id_creds.token == ID_TOKEN_DATA | |||
| assert id_creds._include_email is True | |||
| assert id_creds._target_credentials is credentials | |||
There was a problem hiding this comment.
the same creds are used in ln 469 and 471. So there is no point of making the from_credentials call in 471 I think?
There was a problem hiding this comment.
Updated with a fix for that
clundin25
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
clundin25
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
clundin25
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
clundin25
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
clundin25
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
clundin25
added
kokoro:run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:run
clundin25
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
clundin25
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
from_credentialsmethod should use the specifiedtarget_credentials.