fix: refactor credential subclass parameters #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScruffyProdigy
requested review from
arithmetic1728,
sai-sunder-s and
a team
as code owners
ScruffyProdigy
force-pushed
the
refactor
branch
from
5a48ad5
to
8477917
Compare
ScruffyProdigy
changed the title
clundin25
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
clundin25
reviewed
Aug 2, 2022
clundin25
reviewed
Aug 2, 2022
clundin25
reviewed
Aug 2, 2022
|
Looks like you need to run |
clundin25
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
clundin25
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameters that are unused by the subclasses should be skipped and passed through via kwargs. This will make the code more readable