Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide how to deal with covering import guards #127

Closed
theacodes opened this issue Mar 1, 2017 · 3 comments
Closed

Decide how to deal with covering import guards #127

theacodes opened this issue Mar 1, 2017 · 3 comments
Assignees
Labels
discussion hygiene 🚨 This issue needs some love. testing triage me I really want to be triaged.

Comments

@theacodes
Copy link
Contributor

Context: #125

@theacodes
Copy link
Contributor Author

Since removing the optional dependencies, this is less of a concern. Closing.

@dhermes
Copy link
Contributor

dhermes commented Mar 23, 2017

@jonparrott Why so many ImportError left to catch?

$ git grep 'except ImportError'
additional_packages/google_auth_oauthlib/google_auth_oauthlib/helpers.py:except ImportError:  # pragma: NO COVER
google/__init__.py:except ImportError:
google/auth/_oauth2client.py:except ImportError:
google/auth/_oauth2client.py:except ImportError:
google/auth/app_engine.py:except ImportError:
google/auth/transport/grpc.py:except ImportError:  # pragma: NO COVER
google/auth/transport/requests.py:except ImportError:  # pragma: NO COVER
google/auth/transport/urllib3.py:except ImportError:  # pragma: NO COVER
google/auth/transport/urllib3.py:except ImportError:  # pragma: NO COVER
tests/transport/test_grpc.py:except ImportError:  # pragma: NO COVER
$ # WHEN
$ git log -1 --pretty=%H
1049bb25448696b0958e665eacd13bbd297a42f5

@theacodes
Copy link
Contributor Author

additional_packages/google_auth_oauthlib/google_auth_oauthlib/helpers.py:except ImportError: # pragma: NO COVER

Will fix.

google/init.py:except ImportError:

Part of the namespace package stuff.

google/auth/_oauth2client.py:except ImportError:

Covered

google/auth/app_engine.py:except ImportError:

Covered

google/auth/transport/*.py:except ImportError: # pragma: NO COVER

Transports are all optional, and must be explicitly installed. I do not see this as a problem. I may be able to be convinced otherwise.

tests/transport/test_grpc.py:except ImportError: # pragma: NO COVER

This is needed so PyPy doesn't 'splode.

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion hygiene 🚨 This issue needs some love. testing triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants