Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add WebAuthn handler component #1464

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

ikimonogakari
Copy link
Contributor

Add WebAuthnHandler interface to support WebAuthn get request.

Also implemented PluginHandler, which implements WebAuthnHandler interface by delegating the request to a plugin registered through an environement variable.

This module can support different WebAuthn handling mechanism by providing different WebAuthnHandler interface implementations, such as calling python-fido2.

@ikimonogakari ikimonogakari requested review from a team as code owners February 6, 2024 02:45
@westarle
Copy link

westarle commented Feb 7, 2024

Is it possible to generate these classes based on the standard? Or how do you expect them to stay true to https://www.w3.org/TR/webauthn-3 ?

Can you please separate the Python representation of https://www.w3.org/TR/webauthn-3 from the plugin execution parts? (2 files, maybe 2 PRs)

@ikimonogakari
Copy link
Contributor Author

@westarle As we discussed,

  1. I split the the request/response type definition into a separate file.
  2. Added unit tests to guard the correct translation between JSON and python classes.

@arithmetic1728 arithmetic1728 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 28, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 28, 2024
@ikimonogakari ikimonogakari requested a review from a team as a code owner March 28, 2024 23:13
@arithmetic1728 arithmetic1728 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 28, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 28, 2024
@arithmetic1728 arithmetic1728 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 29, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 29, 2024
@arithmetic1728 arithmetic1728 merged commit e25f336 into googleapis:main Mar 29, 2024
14 checks passed
Copy link
Contributor

@BigTailWolf BigTailWolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 6, 2024
🤖 I have created a release *beep* *boop*
---


## [2.30.0](https://togithub.com/googleapis/google-auth-library-python/compare/v2.29.0...v2.30.0) (2024-06-06)


### Features

* Add WebAuthn plugin component to handle WebAuthn get assertion request ([#1464](https://togithub.com/googleapis/google-auth-library-python/issues/1464)) ([e25f336](https://togithub.com/googleapis/google-auth-library-python/commit/e25f336ab49c2018a222458a95ebe083e8a4eb2a))
* ECP Provider drop cryptography requirement ([#1524](https://togithub.com/googleapis/google-auth-library-python/issues/1524)) ([a821d71](https://togithub.com/googleapis/google-auth-library-python/commit/a821d719e2fc7bcdc21737fdf175d6f06aa9a56a))
* Enable webauthn plugin for security keys ([#1528](https://togithub.com/googleapis/google-auth-library-python/issues/1528)) ([e2d5e63](https://togithub.com/googleapis/google-auth-library-python/commit/e2d5e635da2cb2caf8240fb9e07fc381442a9d0c))


### Bug Fixes

* Fix id_token iam endpoint for non-gdu service credentials ([#1506](https://togithub.com/googleapis/google-auth-library-python/issues/1506)) ([93d681e](https://togithub.com/googleapis/google-auth-library-python/commit/93d681e6cfb15eb4a3efada623be8ba73b302257))
* Makes default token_url universe aware ([#1514](https://togithub.com/googleapis/google-auth-library-python/issues/1514)) ([045776e](https://togithub.com/googleapis/google-auth-library-python/commit/045776e5dfa3fb172ffaeb59bfe5c637778a5d34))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants