feat: Enable webauthn plugin for security keys #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpisunyer
changed the title
|
@ikimonogakari could you take a look as well? Thanks! |
ikimonogakari
approved these changes
Jun 5, 2024
Move key press prompt and remove TODO question.
arithmetic1728
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Fix lint and mypy errors.
arithmetic1728
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
sai-sunder-s
reviewed
Jun 5, 2024
clundin25
reviewed
Jun 5, 2024
clundin25
reviewed
Jun 5, 2024
clundin25
reviewed
Jun 5, 2024
clundin25
reviewed
Jun 5, 2024
clundin25
reviewed
Jun 5, 2024
Check dict accesses for None. Remove commented out line.
Change _urlsafe_b64recode to _unpadded_urlsafe_b64recode for clarity.
arithmetic1728
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
clundin25
approved these changes
Jun 6, 2024
Fix broken test and add test clauses to bring coverage to 100%.
…' into webauthn-2024-05-16
sai-sunder-s
approved these changes
Jun 6, 2024
arithmetic1728
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
arithmetic1728
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
🤖 I have created a release *beep* *boop* --- ## [2.30.0](https://togithub.com/googleapis/google-auth-library-python/compare/v2.29.0...v2.30.0) (2024-06-06) ### Features * Add WebAuthn plugin component to handle WebAuthn get assertion request ([#1464](https://togithub.com/googleapis/google-auth-library-python/issues/1464)) ([e25f336](https://togithub.com/googleapis/google-auth-library-python/commit/e25f336ab49c2018a222458a95ebe083e8a4eb2a)) * ECP Provider drop cryptography requirement ([#1524](https://togithub.com/googleapis/google-auth-library-python/issues/1524)) ([a821d71](https://togithub.com/googleapis/google-auth-library-python/commit/a821d719e2fc7bcdc21737fdf175d6f06aa9a56a)) * Enable webauthn plugin for security keys ([#1528](https://togithub.com/googleapis/google-auth-library-python/issues/1528)) ([e2d5e63](https://togithub.com/googleapis/google-auth-library-python/commit/e2d5e635da2cb2caf8240fb9e07fc381442a9d0c)) ### Bug Fixes * Fix id_token iam endpoint for non-gdu service credentials ([#1506](https://togithub.com/googleapis/google-auth-library-python/issues/1506)) ([93d681e](https://togithub.com/googleapis/google-auth-library-python/commit/93d681e6cfb15eb4a3efada623be8ba73b302257)) * Makes default token_url universe aware ([#1514](https://togithub.com/googleapis/google-auth-library-python/issues/1514)) ([045776e](https://togithub.com/googleapis/google-auth-library-python/commit/045776e5dfa3fb172ffaeb59bfe5c637778a5d34)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on the earlier PR from ikimonogakari, this code will route security key requests to the webauthn plugin if the GOOGLE_AUTH_WEBAUTHN_PLUGIN env variable is set. If the variable is not set, the existing code path continues to be executed.