Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds support for X509 workload credential type #1541

Merged
merged 11 commits into from
Jul 2, 2024
Merged

feat: adds support for X509 workload credential type #1541

merged 11 commits into from
Jul 2, 2024

Conversation

aeitzman
Copy link
Contributor

No description provided.

@aeitzman aeitzman added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 20, 2024
@aeitzman aeitzman requested review from a team as code owners June 20, 2024 21:05
lsirac
lsirac reviewed Jun 25, 2024
View reviewed changes
google/auth/external_account.py Outdated Show resolved Hide resolved
google/auth/identity_pool.py Outdated Show resolved Hide resolved
google/auth/external_account.py Outdated Show resolved Hide resolved
tests/test_external_account.py Outdated Show resolved Hide resolved
aeitzman and others added 2 commits June 26, 2024 10:04
@aeitzman @lsirac
Apply suggestions from code review
7e7bffa 
Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>
@aeitzman
fix: responding to PR comments
e2ab193
@aeitzman @clundin25
Apply suggestions from code review
457cdf9 
Co-authored-by: Carl Lundin <108372512+clundin25@users.noreply.github.com>
@aeitzman aeitzman removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 2, 2024
@aeitzman aeitzman added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 2, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 2, 2024
@aeitzman aeitzman merged commit 1270217 into googleapis:main Jul 2, 2024
14 checks passed
@release-please release-please bot mentioned this pull request Jul 2, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 8, 2024
@release-please
chore(main): release 2.32.0 (#1546)
8338594 
🤖 I have created a release *beep* *boop*
---


## [2.32.0](https://togithub.com/googleapis/google-auth-library-python/compare/v2.31.0...v2.32.0) (2024-07-08)


### Features

* Adds support for X509 workload credential type ([#1541](https://togithub.com/googleapis/google-auth-library-python/issues/1541)) ([1270217](https://togithub.com/googleapis/google-auth-library-python/commit/1270217556a0249b6be8824e2b6209371f24e400))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
ohmayr pushed a commit that referenced this pull request Jul 12, 2024
@release-please @ohmayr
chore(main): release 2.32.0 (#1546)
b6d75c1 
🤖 I have created a release *beep* *boop*
---


## [2.32.0](https://togithub.com/googleapis/google-auth-library-python/compare/v2.31.0...v2.32.0) (2024-07-08)


### Features

* Adds support for X509 workload credential type ([#1541](https://togithub.com/googleapis/google-auth-library-python/issues/1541)) ([1270217](https://togithub.com/googleapis/google-auth-library-python/commit/1270217556a0249b6be8824e2b6209371f24e400))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsirac lsirac lsirac left review comments

@clundin25 clundin25 clundin25 approved these changes

Assignees

@lsirac lsirac

@arithmetic1728 arithmetic1728

@clundin25 clundin25

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aeitzman @lsirac @clundin25 @arithmetic1728