Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asyncio/tornado support #321

Closed
stalkerg opened this issue Jan 31, 2019 · 8 comments
Closed

Add asyncio/tornado support #321

stalkerg opened this issue Jan 31, 2019 · 8 comments
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@stalkerg
Copy link

Subj.
My current project was written on Tornado with async/await and I need to integrate google auth.
Looks like current "transport" system not so good for async/await environment because you call it outside and I can't call async methods inside.
Probably I can run request as an independent task on the loop but it ugly solution.

Thanks.

@theacodes
Copy link
Contributor

HI @stalkerg. It's something we want to do eventually, but we haven't found a feasible way of doing this while still supporting Python 2 users. Thankfully, we're on track to drop 2 support in 2020.

I'm going to close this issue for now, but know that it is (eventually) on our roadmap.

In the meantime, if you're super enterprising most of the private code here is designed to transport agnostic, though might have some assumptions about blocking vs non-blocking behavior, so it may be possible to get a minimal set of functionality working for your use case.

@Lawouach
Copy link

Hi there,

Just wanted to raise a friendly flag of a Python3 only user who is looking forward for an async version indeed. The entire google suite of client libs is one of the last that doesn't support in some capacity async and it means we always have to craft around it somehow. It always feels brittle. So, again, looking forward some progress on this even though it means waiting until 2020.

Thanks.

@busunkim96
Copy link
Contributor

Hi @Lawouach - the previous timeline still applies. We're looking forward to adding support in the next year.

@Lawouach
Copy link

Thanks. That's awesome news!

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 7, 2020
@boxysean
Copy link

I am also looking for async/await functionality from Google's python client libraries for use in a web server built on Tornado.

@stalkerg
Copy link
Author

@Lawouach 2020 is here, do you have any news about async/await?

@kamyar
Copy link

kamyar commented Jun 3, 2020

Is there any development on this front?
Also can you please reopen this issue as it is mentioned as a blocker for firebase/firebase-admin-python#104 ?
We have been using firestore and lack of async is a very big downside of firestore.
If async supported is not planned for google services, It would be nice if we know beforehand so we can plan our migration to services that support it. Lack of this feature is causing us both money and product quality tbh.

@Lawouach
Copy link

Lawouach commented Jun 3, 2020

@stalkerg nope.

To be fair I've moved to Authlib for OAuth specifically. It doesn't help with other google libraries based on this one but I have no visibility on what Google does sadly :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

7 participants