Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make gRPC auth plugin non-blocking + add default timeout value f… #390

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Conversation

michaelawyu
Copy link
Contributor

…or requests transport

This commit includes the following changes:

  • transport.grpc.AuthMetadataPlugin is now non-blocking as gRPC requires
  • transport.requests.Request now has a default timeout value of 120 seconds so that token refreshing will not be stuck

Resolves: #351

…or requests transport

This commit includes the following changes:
- `transport.grpc.AuthMetadataPlugin` is now non-blocking as gRPC requires
- `transport.requests.Request` now has a default timeout value of 120 seconds so that token refreshing will not be stuck

Resolves: #351
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 20, 2019
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small question.

Thank you for putting together this PR!

tests/transport/test_grpc.py Show resolved Hide resolved
@busunkim96
Copy link
Contributor

Please merge when you're ready. The release-please bot should open up a PR soon afterwards that you can also review and merge. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AuthMetadataPlugin: gRPC requires it to not block; causes timeouts to not be respected
3 participants