New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add SslCredentials class for mTLS ADC #448

Merged

arithmetic1728 merged 18 commits into googleapis:master from arithmetic1728:master

Mar 19, 2020

Contributor

arithmetic1728 commented Feb 24, 2020

add SslCredentials class for mTLS ADC (linux only)

go/adc-for-dca-python

googlebot added the cla: yes label

arithmetic1728 requested a review from busunkim96

February 24, 2020 08:53


          feat: add SslCredentials class for mTLS ADC (linux)

781654d

arithmetic1728 requested a review from broady

February 24, 2020 08:58

arithmetic1728 changed the title ~~add mTLS support for grpc~~ feat: add SslCredentials class for mTLS ADC (linux)

Contributor Author

arithmetic1728 commented Feb 24, 2020

For grpc mTLS ADC support.


          Fix JSON exception issue

2f0aaa7

arithmetic1728 requested a review from software-dov

February 24, 2020 18:24

busunkim96 suggested changes

View reviewed changes

google/auth/transport/_mtls_helper.py Outdated Show resolved Hide resolved

google/auth/transport/_mtls_helper.py Outdated Show resolved Hide resolved

google/auth/transport/_mtls_helper.py Show resolved Hide resolved

google/auth/transport/_mtls_helper.py Show resolved Hide resolved

google/auth/transport/_mtls_helper.py Outdated Show resolved Hide resolved

google/auth/transport/_mtls_helper.py Outdated Show resolved Hide resolved

google/auth/transport/_mtls_helper.py Outdated Show resolved Hide resolved

google/auth/transport/_mtls_helper.py Outdated Show resolved Hide resolved

google/auth/transport/_mtls_helper.py Outdated Show resolved Hide resolved

google/auth/transport/_mtls_helper.py Outdated Show resolved Hide resolved


          Update google/auth/transport/_mtls_helper.py

e628966

Co-Authored-By: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>

broady reviewed

View reviewed changes

google/auth/transport/_mtls_helper.py Outdated Show resolved Hide resolved

broady reviewed

View reviewed changes

google/auth/transport/_mtls_helper.py Outdated Show resolved Hide resolved

broady reviewed

View reviewed changes

google/auth/transport/_mtls_helper.py Outdated Show resolved Hide resolved

broady reviewed

View reviewed changes

google/auth/transport/_mtls_helper.py Outdated Show resolved Hide resolved

broady reviewed

View reviewed changes

google/auth/transport/_mtls_helper.py Outdated Show resolved Hide resolved

arithmetic1728 and others added 2 commits

February 25, 2020 23:29


          modify the code based on comments

ed65141


          Merge pull request #1 from arithmetic1728/fix

fb36050

modify the code based on comments

broady reviewed

View reviewed changes

google/auth/transport/_mtls_helper.py Show resolved Hide resolved

broady reviewed

View reviewed changes

google/auth/transport/grpc.py Outdated Show resolved Hide resolved

broady reviewed

View reviewed changes

google/auth/transport/grpc.py Outdated Show resolved Hide resolved

broady reviewed

View reviewed changes

google/auth/transport/grpc.py Show resolved Hide resolved

broady reviewed

View reviewed changes

google/auth/transport/grpc.py Outdated Show resolved Hide resolved

broady commented Feb 26, 2020

Looks pretty good overall... do you have it hooked up to secure_authorized_channel, or is that for later?

arithmetic1728 and others added 2 commits

February 26, 2020 12:57


          fix docstring

f5671e4


          Merge pull request #2 from arithmetic1728/fix

a8618fe

fix docstring

Contributor Author

arithmetic1728 commented Feb 26, 2020

Looks pretty good overall... do you have it hooked up to secure_authorized_channel, or is that for later?

Hooked it up to secure_authorized_channel in the new commit.

arithmetic1728 and others added 4 commits

February 26, 2020 17:12


          throw exceptions to user, add client_cert_callback

296977e


          Merge pull request #3 from arithmetic1728/fix

03a147f

throw exceptions to user, add client_cert_callback


          throw exception is metadata file is not json

7d8dff7


          Merge pull request #5 from arithmetic1728/fix

c49a79f

throw exception is metadata file is not json

arithmetic1728 changed the title ~~feat: add SslCredentials class for mTLS ADC (linux)~~ feat: add SslCredentials class for mTLS ADC


          fix typo

1dc22c0

busunkim96 suggested changes

View reviewed changes

Contributor

busunkim96 left a comment

Mostly nits on the docstrings to get the style consistent with existing functions. 😄

Do you have plans for a system test, or is that infeasible?

google/auth/transport/_mtls_helper.py Outdated Show resolved Hide resolved

google/auth/transport/grpc.py Show resolved Hide resolved

google/auth/transport/_mtls_helper.py Outdated Show resolved Hide resolved

google/auth/transport/_mtls_helper.py Outdated Show resolved Hide resolved

google/auth/transport/_mtls_helper.py Outdated Show resolved Hide resolved

google/auth/transport/grpc.py Outdated Show resolved Hide resolved

google/auth/transport/grpc.py Outdated Show resolved Hide resolved

google/auth/transport/grpc.py Outdated Show resolved Hide resolved

google/auth/transport/grpc.py Outdated Show resolved Hide resolved

google/auth/transport/grpc.py Outdated Show resolved Hide resolved


          update

12e69d8

busunkim96 reviewed

View reviewed changes

google/auth/transport/grpc.py Outdated Show resolved Hide resolved

googleapis deleted a comment from busunkim96

Contributor Author

arithmetic1728 commented Mar 5, 2020

Mostly nits on the docstrings to get the style consistent with existing functions. 😄

Do you have plans for a system test, or is that infeasible?

Yes, will do in a different PR.


          update docstring

b2e394b

arithmetic1728 requested a review from bshaffer

March 5, 2020 22:36

busunkim96 approved these changes

View reviewed changes

arithmetic1728 mentioned this pull request

feat: add mTLS ADC support for HTTP #453

Closed


          Merge branch 'master' into master

c510abe

arithmetic1728 mentioned this pull request

feat: add mTLS ADC support for HTTP #457

Merged

bshaffer reviewed

View reviewed changes

google/auth/transport/grpc.py Outdated Show resolved Hide resolved

arithmetic1728 added 2 commits

March 11, 2020 12:11


          don't use ADC if client_cert_callback is provided

e6f2f10


          update docstring

da135ad

arithmetic1728 requested a review from chrisdunelm

March 17, 2020 18:04

chrisdunelm reviewed

View reviewed changes

google/auth/transport/grpc.py Show resolved Hide resolved

chrisdunelm approved these changes

View reviewed changes

chrisdunelm left a comment

LGTM


          Merge branch 'master' into master

514ffa9

arithmetic1728 merged commit dafb41f into googleapis:master

busunkim96 mentioned this pull request

chore: release 1.12.0 #463

Merged

gcf-merge-on-green bot pushed a commit that referenced this pull request


          chore: release 1.12.0 (#463)

f79cf9a

🤖 I have created a release \*beep\* \*boop\* 
---
## [1.12.0](https://www.github.com/googleapis/google-auth-library-python/compare/v1.11.3...v1.12.0) (2020-03-25)


### Features

* add mTLS ADC support for HTTP ([#457](https://www.github.com/googleapis/google-auth-library-python/issues/457)) ([bb9215a](https://www.github.com/googleapis/google-auth-library-python/commit/bb9215ad6dee6c1dc7f255a2e4ed7011b85bd6cf))
* add SslCredentials class for mTLS ADC ([#448](https://www.github.com/googleapis/google-auth-library-python/issues/448)) ([dafb41f](https://www.github.com/googleapis/google-auth-library-python/commit/dafb41fae3f513ea9a4f93404f6148bee7dda202))
* fetch id token from GCE metadata server ([#462](https://www.github.com/googleapis/google-auth-library-python/issues/462)) ([97e7700](https://www.github.com/googleapis/google-auth-library-python/commit/97e7700da031bfd80b63b1a3d2abc29c500936ef))


### Bug Fixes

* don't use threads for gRPC AuthMetadataPlugin ([#467](https://www.github.com/googleapis/google-auth-library-python/issues/467)) ([ee373f8](https://www.github.com/googleapis/google-auth-library-python/commit/ee373f88b512a38e791a1c085452c6c6da501eb6))
* make ThreadPoolExecutor a class var ([#461](https://www.github.com/googleapis/google-auth-library-python/issues/461)) ([b526473](https://www.github.com/googleapis/google-auth-library-python/commit/b5264730603947295cc97ecff2f6aef84aa3d6e9))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

broady broady left review comments

bshaffer bshaffer left review comments

chrisdunelm chrisdunelm approved these changes

busunkim96 busunkim96 approved these changes

software-dov Awaiting requested review from software-dov