Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invalid expiry type #481

Merged
merged 2 commits into from
Apr 1, 2020
Merged

fix: invalid expiry type #481

merged 2 commits into from
Apr 1, 2020

Conversation

arithmetic1728
Copy link
Contributor

@arithmetic1728 arithmetic1728 commented Apr 1, 2020 •
edited
Loading

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 1, 2020
@arithmetic1728 arithmetic1728 changed the title fix: invalid expiry type #479 fix: invalid expiry type Apr 1, 2020
busunkim96
busunkim96 approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

google/auth/compute_engine/credentials.py Outdated Show resolved Hide resolved
@arithmetic1728 @busunkim96
Update google/auth/compute_engine/credentials.py
c99a571 
Co-Authored-By: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
@arithmetic1728 arithmetic1728 merged commit 7ae9a28 into master Apr 1, 2020
@arithmetic1728 arithmetic1728 deleted the sijun/idtoken branch April 1, 2020 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid type for expiry when using GCE metadata server
3 participants
@arithmetic1728 @busunkim96 @googlebot