Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no warning if quota_project_id is given #537

Merged
merged 2 commits into from
Jun 18, 2020
Merged

fix: no warning if quota_project_id is given #537

merged 2 commits into from
Jun 18, 2020

Conversation

arithmetic1728
Copy link
Contributor

If user account cred has 'quota_project_id', ignore the warning.

Implementing http://shortn/_YUlAgzL40H

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 17, 2020
@arithmetic1728
Copy link
Contributor Author

fixes #520

busunkim96
busunkim96 approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit on the warning text, otherwise LGTM.

Thanks for fixing this!

google/auth/_default.py Outdated Show resolved Hide resolved
@arithmetic1728 @busunkim96
Update google/auth/_default.py
346dee0 
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
@arithmetic1728 arithmetic1728 added the automerge Merge the pull request once unit tests and other checks pass. label Jun 18, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit f30b45a into master Jun 18, 2020
@arithmetic1728 arithmetic1728 deleted the sijun-quota branch June 18, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arithmetic1728 @busunkim96 @googlebot