Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix intersphinx link for 'requests-oauthlib' #921

Merged
merged 2 commits into from Nov 18, 2021
Merged

docs: fix intersphinx link for 'requests-oauthlib' #921

merged 2 commits into from Nov 18, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 18, 2021

Closes #920.

@tseaver tseaver requested review from silvolu and a team as code owners November 18, 2021 14:44
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 18, 2021
@tseaver tseaver mentioned this pull request Nov 18, 2021
Merged
plamut
plamut approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Just wondering how will we make sure the link stays up to date when new versions are released?

@tseaver
Copy link
Contributor Author

tseaver commented Nov 18, 2021

@plamut

Just wondering how will we make sure the link stays up to date when new versions are released?

We don't really depend on the library -- we just reference it in an example in the docs. I guess if they later make a new release and delete the v1.3.0-docs RTD build, we will have to update again.

Funny how the "xxx for humans" crowd is always breaking other projects' builds this way.

@tseaver
Copy link
Contributor Author

tseaver commented Nov 18, 2021

Here's a giggle: the google-auth-oauthlib library, which does use requests-oauthlib, doesn't use its intersphinx inventory, and so wasn't broken by their change.

@tseaver tseaver merged commit 967be4f into main Nov 18, 2021
@tseaver tseaver deleted the 920-fix-requests-oauthlib-intersphinx branch November 18, 2021 15:10
@release-please release-please bot mentioned this pull request Jan 20, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 20, 2022
@release-please
chore(main): release 2.4.0 (#949)
88580b4 
🤖 I have created a release *beep* *boop*
---


## [2.4.0](v2.3.3...v2.4.0) (2022-01-20)


### Features

* add 'py.typed' declaration ([#919](#919)) ([c993504](c993504))
* add api key support ([#826](#826)) ([3b15092](3b15092))


### Bug Fixes

* **deps:** allow cachetools 5.0 for python 3.7+ ([#937](#937)) ([1eae37d](1eae37d))
* fix the message format for metadata server exception ([#916](#916)) ([e756f08](e756f08))


### Documentation

* fix intersphinx link for 'requests-oauthlib' ([#921](#921)) ([967be4f](967be4f))
* note ValueError in `verify_oauth2_token` ([#928](#928)) ([82bc5f0](82bc5f0))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

@busunkim96 busunkim96 Awaiting requested review from busunkim96

@arithmetic1728 arithmetic1728 Awaiting requested review from arithmetic1728

@silvolu silvolu Awaiting requested review from silvolu

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intersphinx URL for 'requests-oauthlib' now 404s
2 participants
@tseaver @plamut