Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite all throwing methods to return Result<Value, Error> #34

Open
timburks opened this issue Mar 31, 2020 · 3 comments
Open

Rewrite all throwing methods to return Result<Value, Error> #34

timburks opened this issue Mar 31, 2020 · 3 comments
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@timburks
Copy link
Contributor

timburks commented Mar 31, 2020

Swift 5 added a standard Result enum that represents function results that can include errors. This is more concise and seems preferable to try/catch handling.

Should we update this library to use Result instead of throw (and bump the release number to 0.6)?

cc @0xced it looks like you've done this already: 0xced@a25ec65

@0xced
Copy link
Contributor

0xced commented Apr 3, 2020

Indeed, I already started to work on this. I'll submit a pull request when it's ready.

@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Feb 25, 2021
@JustinBeckwith JustinBeckwith added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Feb 25, 2021
@yoshi-automation yoshi-automation removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Feb 25, 2021
@dcow
Copy link
Contributor

dcow commented Dec 1, 2021

@0xced is this something you'd still submit if bumped or have you moved on to other things?

@0xced
Copy link
Contributor

0xced commented Dec 29, 2021

I still have pending work on my result branch that I have not even committed. It was almost two years ago, it may not even compile… But if you're interested, I can commit and push those changes so that someone else can take over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

5 participants