Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document gRPC roots.pem requirements in top-level README. #2862

Closed
coryan opened this issue Jul 9, 2019 · 3 comments
Closed

Document gRPC roots.pem requirements in top-level README. #2862

coryan opened this issue Jul 9, 2019 · 3 comments
Assignees
Labels
type: docs Improvement to the documentation for an API.

Comments

@coryan
Copy link
Member

coryan commented Jul 9, 2019

The examples/README documents how to setup the roots.pem file for gRPC:

https://github.com/googleapis/google-cloud-cpp/blob/master/google/cloud/bigtable/examples/README.md#configure-grpc-root-certificates

This should be also documented in the bigtable/README.md file, and in the quick start guide, and in the landing page for the reference guide.

@coryan coryan added the type: docs Improvement to the documentation for an API. label Jul 9, 2019
@coryan
Copy link
Member Author

coryan commented Jul 9, 2019

Also the current documentation suggests using third_party/grpc which is not really a directory.

@coryan
Copy link
Member Author

coryan commented Jul 10, 2019

Note that this is not needed for Linux, gRPC uses the native trust store in that platform, but it does not on macOS, the PR to fix that was closed without merging:

grpc/grpc#16246

nor does it work on Windows:

grpc/grpc#16571

@coryan coryan added this to High priority in Customer Issues Jul 17, 2019
@coryan coryan moved this from High priority to Low priority in Customer Issues Aug 8, 2019
@coryan coryan moved this from Low priority to High priority in Customer Issues Aug 28, 2019
@coryan
Copy link
Member Author

coryan commented May 15, 2020

Actually, this is now done at the README for each quickstart program. Closing.

@coryan coryan closed this as completed May 15, 2020
Customer Issues automation moved this from High priority to Closed May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs Improvement to the documentation for an API.
Projects
No open projects
Customer Issues
  
Closed
Development

No branches or pull requests

1 participant