Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firestore: not returning exact error #10061

Open
Jason-SP-Chien opened this issue Apr 29, 2024 · 0 comments
Open

firestore: not returning exact error #10061

Jason-SP-Chien opened this issue Apr 29, 2024 · 0 comments
Assignees
Labels
api: firestore Issues related to the Firestore API. triage me I really want to be triaged.

Comments

@Jason-SP-Chien
Copy link

Client

Firestore

Code

In firestore/bulkwriter.go, we saw methods of BulkWriter including Create, Delete, Set, and Update. They do not throw the error returned by newXXXWrites. The error itself is replaced by fmt.Errorf("firestore: cannot XXX doc %v", doc.ID), which cost us time to trace out what really happened inside these operations.

Expected behavior

The error itself should be either wrapped or directly returned.

Actual behavior

It is replaced by an almost useless error message.

@Jason-SP-Chien Jason-SP-Chien added the triage me I really want to be triaged. label Apr 29, 2024
@product-auto-label product-auto-label bot added the api: firestore Issues related to the Firestore API. label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

2 participants