Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner: (Doc) Missing error handling after BufferWrite #3802

Closed
sryoya opened this issue Mar 12, 2021 · 0 comments · Fixed by #3803
Closed

spanner: (Doc) Missing error handling after BufferWrite #3802

sryoya opened this issue Mar 12, 2021 · 0 comments · Fixed by #3803
Assignees
@skuruppu
Labels
api: spanner Issues related to the Spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@sryoya
Copy link
Contributor

sryoya commented Mar 12, 2021

Is your feature request related to a problem? Please describe.
The below example code in the doc doesn't catch and handle the error from txn.BufferWrite . I guess it disables the retry to be triggered by this error.

google-cloud-go/spanner/doc.go

Line 303 in f321666

txn.BufferWrite([]*spanner.Mutation{m})

Describe the solution you'd like
Just make it catch and return the error.
@sryoya sryoya added the triage me I really want to be triaged. label Mar 12, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Mar 12, 2021
@sryoya sryoya mentioned this issue Mar 12, 2021
Merged
@skuruppu skuruppu added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skuruppu skuruppu

Labels
api: spanner Issues related to the Spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(spanner): fix the result handling after BufferWrite sryoya/google-cloud-go
2 participants
@skuruppu @sryoya