Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: trace streaming grpc calls #4234

Closed
crwilcox opened this issue Jun 8, 2021 · 1 comment
Closed

all: trace streaming grpc calls #4234

crwilcox opened this issue Jun 8, 2021 · 1 comment
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@crwilcox
Copy link
Contributor

crwilcox commented Jun 8, 2021

In order to quiet the logs as reported in #4133 we now only trace the time to first result for a streaming call. It may be interesting if we could trace/report on additional rpc calls.

This is a bit niche, and likely below in priority to finding a way to provide rpc traces for unary calls, but making a note here.

@crwilcox crwilcox added triage me I really want to be triaged. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jun 8, 2021
@codyoss codyoss self-assigned this Jun 8, 2021
@codyoss codyoss removed the triage me I really want to be triaged. label Jun 8, 2021
@codyoss
Copy link
Member

codyoss commented Apr 16, 2024

Closing in favor of #4237

@codyoss codyoss closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants