Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsublite/internal/wire: TestAssigningSubscriberAddRemovePartitions failed #4516

Closed
flaky-bot bot opened this issue Jul 29, 2021 · 1 comment · Fixed by #4564
Closed

pubsublite/internal/wire: TestAssigningSubscriberAddRemovePartitions failed #4516

flaky-bot bot opened this issue Jul 29, 2021 · 1 comment · Fixed by #4564
Assignees
@tmdiep
Labels
api: pubsublite Issues related to the Pub/Sub Lite API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Jul 29, 2021

Note: #3826 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.

commit: 9401be5
buildURL: Build Status, Sponge
status: failed

Test output
verifier.go:226: call(2): did not receive expected request:
    [*pubsublite.PartitionAssignmentRequest] ack:{}
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jul 29, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the Pub/Sub Lite API. label Jul 29, 2021
@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Jul 29, 2021
@flaky-bot
Copy link
Author

flaky-bot bot commented Jul 29, 2021

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.

When run at the same commit (9401be5), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Aug 4, 2021
@tmdiep tmdiep self-assigned this Aug 4, 2021
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Aug 5, 2021
@tmdiep tmdiep added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Aug 6, 2021
@tmdiep tmdiep mentioned this issue Aug 6, 2021
Merged
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Aug 7, 2021
@flaky-bot flaky-bot bot mentioned this issue Aug 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmdiep tmdiep

Labels
api: pubsublite Issues related to the Pub/Sub Lite API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(pubsublite): fix flaky TestAssigningSubscriberAddRemovePartitions tmdiep/google-cloud-go
2 participants
@tmdiep @yoshi-automation