New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pubsub/pstest): add topic retention support #4790
Merged
hongalex
merged 10 commits into
googleapis:main
from
hongalex:feat-pstest-topic-retention
Mar 8, 2022
Merged
feat(pubsub/pstest): add topic retention support #4790
hongalex
merged 10 commits into
googleapis:main
from
hongalex:feat-pstest-topic-retention
Mar 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ibc7552862e10783ee169c5eed5b81f81d651274a
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Sep 21, 2021
codyoss
approved these changes
Sep 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
product-auto-label
bot
added
the
stale: extraold
Pull request is critically old and needs prioritization.
label
Jan 7, 2022
BrennaEpp
pushed a commit
to BrennaEpp/google-cloud-go
that referenced
this pull request
Mar 10, 2022
* feat(pubsub/pstest): add topic retention support * use testutil.Diff to compare durationpb Change-Id: Ibc7552862e10783ee169c5eed5b81f81d651274a * add subscription field test * fix sclient * update test comparison * allow nil retention duration in fake * make createtopic errors transient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: pubsub
Issues related to the Pub/Sub API.
cla: yes
This human has signed the Contributor License Agreement.
size: s
Pull request size is small.
stale: extraold
Pull request is critically old and needs prioritization.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.