-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spanner): add database roles #5701
feat(spanner): add database roles #5701
Conversation
Adding do not merge label to avoid accidental merges. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, any reasons why we did not dd the role in BatchCreateSessions requests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other TODO's
-
Add tests that use DROP ROLE, REVOKE. (We don't need to test role inheritance, thats sufficiently covered in backend unit tests.
-
Implement/Add tests for ListDatabaseRoles.
I did add it, it's part of
I added these to I'll work on ListDatabaseRoles soon. |
7cc0651
to
3ada697
Compare
bf8dc11
to
1d7195c
Compare
Adds the ability to specify a database role on requests.