Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spanner/spansql): support GROUP BY without an aggregation function #5717

Merged
merged 2 commits into from
Mar 4, 2022
Merged

fix(spanner/spansql): support GROUP BY without an aggregation function #5717

merged 2 commits into from
Mar 4, 2022

Conversation

rahul2393
Copy link
Contributor

Fixes: #5676

@rahul2393 rahul2393 requested review from a team as code owners March 3, 2022 08:41
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the Spanner API. labels Mar 3, 2022
@rahul2393 rahul2393 merged commit c819ee9 into googleapis:main Mar 4, 2022
@rahul2393 rahul2393 deleted the spansql-groupby branch March 4, 2022 05:34
@release-please release-please bot mentioned this pull request Mar 4, 2022
Merged
BrennaEpp pushed a commit to BrennaEpp/google-cloud-go that referenced this pull request Mar 10, 2022
@rahul2393 @BrennaEpp
fix(spanner/spansql): support GROUP BY without an aggregation function (
dc9fe15 
googleapis#5717)

Co-authored-by: Rahul Yadav <irahul@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengfengli hengfengli hengfengli approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spanner/spannertest: GROUP BY without an aggregation function returns all rows
2 participants
@rahul2393 @hengfengli