Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spanner/spannertest): Improve DDL application delay cancellation. #5874

Merged
merged 1 commit into from Apr 8, 2022
Merged

fix(spanner/spannertest): Improve DDL application delay cancellation. #5874

merged 1 commit into from Apr 8, 2022

Conversation

dsymonds
Copy link
Contributor

@dsymonds dsymonds commented Apr 8, 2022

Client code that applies a DDL change and waits for it should get a fast
response. To avoid triggering the standard polling delay, give the LRO a
chance to complete when the first status RPC (GetOperation) occurs on
any particular LRO.

Fixes #5406.

Client code that applies a DDL change and waits for it should get a fast
response. To avoid triggering the standard polling delay, give the LRO a
chance to complete when the first status RPC (GetOperation) occurs on
any particular LRO.

Fixes #5406.
@dsymonds dsymonds requested review from a team as code owners April 8, 2022 02:37
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the Spanner API. labels Apr 8, 2022
@dsymonds
Copy link
Contributor Author

dsymonds commented Apr 8, 2022

@rahul2393

@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 8, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 8, 2022
@rahul2393
Copy link
Contributor

Thanks @dsymonds for opening the PR, LGTM

@rahul2393 rahul2393 merged commit 08f1e72 into googleapis:main Apr 8, 2022
@dsymonds dsymonds deleted the faster-delay branch April 8, 2022 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanner/spannertest: delay during UpdateDatabaseDdl calls
3 participants