Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(recaptchaenterprise/v2): Release breaking changes as v2 module #6062

Merged
merged 10 commits into from
May 23, 2022

Conversation

quartzmo
Copy link
Member

BREAKING CHANGE: parent changed to project in googleapis/go-genproto#808

@quartzmo quartzmo requested a review from a team as a code owner May 19, 2022 16:24
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: recaptchaenterprise Issues related to the reCAPTCHA API. labels May 19, 2022
@quartzmo quartzmo force-pushed the gen-recaptchaenterprise-v2 branch from fbb3000 to 3dcc478 Compare May 19, 2022 16:24
@quartzmo quartzmo changed the title feat!(recaptchaenterprise/v2): Release breaking changes as v2 module feat(recaptchaenterprise/v2): Release breaking changes as v2 module May 19, 2022
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quartzmo
Copy link
Member Author

@codyoss PTAL at my test fix, thanks.

@codyoss
Copy link
Member

codyoss commented May 23, 2022

LGTM, but yeah let get an issue filed to make that test better

@quartzmo quartzmo merged commit 1266896 into googleapis:main May 23, 2022
@quartzmo quartzmo deleted the gen-recaptchaenterprise-v2 branch May 23, 2022 16:51
@release-please release-please bot mentioned this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: recaptchaenterprise Issues related to the reCAPTCHA API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants