Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigtable: add full GCPolicy object with PolicyType to bigtable's FamilyInfo #6122

Closed
hoangpham95 opened this issue Jun 2, 2022 · 0 comments · Fixed by #6234
Closed

bigtable: add full GCPolicy object with PolicyType to bigtable's FamilyInfo #6122

hoangpham95 opened this issue Jun 2, 2022 · 0 comments · Fixed by #6234
Assignees
Labels
api: bigtable Issues related to the Bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@hoangpham95
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We want to read the GC Policy from bigtable from the external TF provider, so that we can set the resource correctly on read. Current implementation only returns a string policy.

Describe the solution you'd like
Instead of return a string policy, return the whole object with policy type.

Describe alternatives you've considered
Return just a proto should works, but it's discouraged to pass proto around.

Additional context
This item is needed for setting Terraform resource on read.

@hoangpham95 hoangpham95 added the triage me I really want to be triaged. label Jun 2, 2022
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jun 2, 2022
@telpirion telpirion added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
2 participants