fix(bigquery/storage/managedstorage): improve internal locking #6304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses some potential deadlocks introduced as part of a refactor of critical section code. It adds a testing to help isolate deadlock code, and makes a small change to the retry predicate to disallow retries of context-based errors (cancelations/expirations).
product-auto-label
bot
added
size: l
steffnay
approved these changes
Jul 7, 2022
codyoss
reviewed
Jul 7, 2022
codyoss
reviewed
Jul 7, 2022
codyoss
reviewed
Jul 7, 2022
codyoss
reviewed
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some potential deadlocks introduced as part of a refactor
of critical section code. Based on a suggestion from @fsaintjacques this
PR switches to closures/funcs where unlocking is handled via defer, rather than explicit unlocking.
This PR adds testing to help ensure further refactors don't reintroduce deadlocks in either
the append or stream closure methods.
This PR also includes small change to the retry predicate to disallow retries for
context-based errors (cancelations/expirations).
Fixes #6278