Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spanner): fix pool.numInUse exceeding MaxOpened #6344

Merged
merged 4 commits into from
Jul 19, 2022
Merged

fix(spanner): fix pool.numInUse exceeding MaxOpened #6344

merged 4 commits into from
Jul 19, 2022

Conversation

hengfengli
Copy link
Contributor

Fix a race condition issue that occasionally, pool.numInUse can exceed MaxOpened.

@hengfengli hengfengli self-assigned this Jul 15, 2022
@hengfengli hengfengli requested review from a team as code owners July 15, 2022 01:35
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the Spanner API. labels Jul 15, 2022
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 18, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 19, 2022
rahul2393
rahul2393 approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@rahul2393 rahul2393 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahul2393 rahul2393 merged commit 882b325 into googleapis:main Jul 19, 2022
@release-please release-please bot mentioned this pull request Jul 19, 2022
Merged
@hengfengli hengfengli deleted the fix-sessions-num-in-use-metric branch July 19, 2022 05:42
@osterante osterante mentioned this pull request Feb 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahul2393 rahul2393 rahul2393 approved these changes

Assignees

@hengfengli hengfengli

Labels
api: spanner Issues related to the Spanner API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hengfengli @rahul2393 @kokoro-team