feat(spanner/spansql): support for parsing a DML file #6349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
110y
commented
Jul 17, 2022
| @@ -32,7 +32,8 @@ func TestParseQuery(t *testing.T) { | |||
| want Query | |||
| }{ | |||
| {`SELECT 17`, Query{Select: Select{List: []Expr{IntegerLiteral(17)}}}}, | |||
| {`SELECT Alias AS aka From Characters WHERE Age < @ageLimit AND Alias IS NOT NULL ORDER BY Age DESC LIMIT @limit OFFSET 3` + "\n\t", | |||
| { | |||
There was a problem hiding this comment.
These formatting changes were made by gopls with its gofumpt option.
rahul2393
added
the
priority: p3
|
@rahul2393 How about this PR review progress? |
|
Hello, @zchee this PR will be released in next release, review is in progress. |
|
@rahul2393 Thanks! can't wait to this feature :D |
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
The build was failed due to @rahul2393 Could you please check and rerun the build? |
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
rahul2393
approved these changes
Jul 21, 2022
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spansql.ParseDMLcorresponding to existingParseDDLin order to support for parsing a DML file.Background
As I am a maintainer of the
cloudspannerecosystem/wrench, which is a schema migration tool for Spanner, I'm planning to usespansqlin order to replace the current regex-based parsing.wrenchsupports executing the multiple DMLs in a file, so I'd likespansqlto have theParseDMLfunction same as theParseDDLfunction.Note
This PR does not add support for
Positionof DMLs. It should be added as another PR.