Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub: Return a custom error if pull timeout occurs #67

Closed
rakyll opened this issue Oct 28, 2014 · 4 comments
Closed

pubsub: Return a custom error if pull timeout occurs #67

rakyll opened this issue Oct 28, 2014 · 4 comments
Assignees
@mcgreevy
Labels
api: pubsub Issues related to the Pub/Sub API. 🚨 This issue needs some love. triage me I really want to be triaged.
Milestone
pubsub in beta

Comments

@rakyll
Copy link
Contributor

rakyll commented Oct 28, 2014

No description provided.

@rakyll
Copy link
Contributor Author

rakyll commented Oct 28, 2014

https://codereview.appspot.com/165750043/

@tmatsuo
Copy link
Contributor

tmatsuo commented Oct 28, 2014

I completely agree that the http status code 400 is wrong when there's no message.

However, I think this should be rolled back, or we should add error details to the returned error, because you'll get http status code 400 for other reasons. The simple test case is that you can issue a PullWait call with an empty "" subscription.

At least with the old code, you can distinguish those errors by the error details, but now you can not.

@tmatsuo
Copy link
Contributor

tmatsuo commented Nov 21, 2014

Ping

@rakyll rakyll added this to the M2: bigquery & pubsub milestone Dec 8, 2014
@okdave okdave added the api: pubsub Issues related to the Pub/Sub API. label May 29, 2015
@okdave okdave modified the milestones: pubsub in beta, M2: bigquery & pubsub May 29, 2015
@mcgreevy
Copy link
Contributor

This was fixed in e2fbd20 (ErrPullTimeout was removed).

Notes:

  • the underlying API no longer returns a 400 on timeout.
  • the Pull and PullWait methods are deprecated in favour of Subscription.Pull. The Iterator returned by Subscription.Pull will block until a message is available or the supplied context is cancelled.

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcgreevy mcgreevy

Labels
api: pubsub Issues related to the Pub/Sub API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
pubsub in beta
Development

No branches or pull requests
5 participants
@tmatsuo @rakyll @okdave @mcgreevy @yoshi-automation