Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub: support labels for snapshots #6838

Closed
hongalex opened this issue Oct 11, 2022 · 0 comments · Fixed by #6835
Closed

pubsub: support labels for snapshots #6838

hongalex opened this issue Oct 11, 2022 · 0 comments · Fixed by #6835
Assignees
@hongalex
Labels
api: pubsub Issues related to the Pub/Sub API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@hongalex
Copy link
Member

Is your feature request related to a problem? Please describe.
Cloud Labels are available for topics/subscriptions but not snapshots

Describe the solution you'd like
Add a way to set labels for snapshots

Describe alternatives you've considered
Provide a CreateSnapshotWithConfig and UpdateSnapshot method to match topic/subscription structs but since we can't meaningfully update snapshots, it's simpler to just have a single method to update snapshot labels.

Additional context
@hongalex hongalex added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: pubsub Issues related to the Pub/Sub API. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 11, 2022
@hongalex hongalex self-assigned this Oct 11, 2022
@hongalex hongalex mentioned this issue Oct 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hongalex hongalex

Labels
api: pubsub Issues related to the Pub/Sub API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(pubsub): add support for snapshot labels hongalex/google-cloud-go
1 participant
@hongalex