Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: add ComponentCount to ObjectAttrs #7223

Closed
tritone opened this issue Jan 9, 2023 · 1 comment
Closed

storage: add ComponentCount to ObjectAttrs #7223

tritone opened this issue Jan 9, 2023 · 1 comment
Assignees
@tritone
Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tritone
Copy link
Contributor

tritone commented Jan 9, 2023

The ComponentCount field is available in the object resource in the JSON & gRPC APIs, but it's not currently exposed via the handwritten layer. It should be added to ObjectAttrs.

It should be added to tests:

google-cloud-go/storage/storage_test.go

Line 1727 in 263e3cb

func TestRawObjectToObjectAttrs(t *testing.T) {

google-cloud-go/storage/storage_test.go

Line 1813 in 263e3cb

func TestProtoObjectToObjectAttrs(t *testing.T) {

google-cloud-go/storage/integration_test.go

Line 1616 in 3592917

func TestIntegration_Compose(t *testing.T) {

This is needed to unblock integration for GCSFuse.
@tritone tritone added the triage me I really want to be triaged. label Jan 9, 2023
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jan 9, 2023
@tritone tritone removed api: storage Issues related to the Cloud Storage API. triage me I really want to be triaged. labels Jan 9, 2023
@tritone tritone added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: storage Issues related to the Cloud Storage API. labels Jan 9, 2023
@tritone
Copy link
Contributor Author

tritone commented Jan 24, 2023

Completed in #7230

@tritone tritone closed this as completed Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tritone tritone

Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tritone