Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datastore): adds nil check to AggregationQuery #7376

Merged
merged 7 commits into from
Feb 13, 2023
Merged

fix(datastore): adds nil check to AggregationQuery #7376

merged 7 commits into from
Feb 13, 2023
+38 −0

Conversation

telpirion
Copy link
Contributor

@telpirion telpirion commented Feb 8, 2023 •
edited
Loading

Fixes #7365

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: datastore Issues related to the Datastore API. labels Feb 8, 2023
@telpirion telpirion marked this pull request as ready for review February 8, 2023 01:43
@telpirion telpirion requested review from a team as code owners February 8, 2023 01:43
enocom
enocom reviewed Feb 8, 2023
View reviewed changes
Copy link
Member

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there could be a unit test or two for this? ;-P

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Feb 10, 2023
@telpirion
Copy link
Contributor Author

Unit test added.

@telpirion telpirion enabled auto-merge (squash) February 13, 2023 16:35
@telpirion telpirion merged commit c43b9ed into main Feb 13, 2023
@telpirion telpirion deleted the datastore-query-fix branch February 13, 2023 16:47
@release-please release-please bot mentioned this pull request Feb 13, 2023
Merged
@DustinJSilk DustinJSilk mentioned this pull request Mar 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enocom enocom enocom approved these changes

@kolea2 kolea2 kolea2 approved these changes

@bhshkh bhshkh Awaiting requested review from bhshkh

Assignees

@enocom enocom

Labels
api: datastore Issues related to the Datastore API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datastore: datastore.Client.RunAggregationQuery panics with nil pointer.
3 participants
@telpirion @enocom @kolea2