feat(spanner): add x-goog-spanner-route-to-leader header to Spanner RPC contexts for RW/PDML transactions. #7500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts for RW/PDML transactions.
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
codyoss
changed the title
olavloite
requested changes
Mar 2, 2023
spanner/transaction.go
Outdated
| @@ -1676,7 +1681,7 @@ func (t *writeOnlyTransaction) applyAtLeastOnce(ctx context.Context, ms ...*Muta | |||
| return ToSpannerError(err) | |||
| } | |||
| } | |||
| res, err := sh.getClient().Commit(contextWithOutgoingMetadata(ctx, sh.getMetadata()), &sppb.CommitRequest{ | |||
| res, err := sh.getClient().Commit(contextWithOutgoingMetadata(ctx, sh.getMetadata(), false), &sppb.CommitRequest{ | |||
There was a problem hiding this comment.
Why is this never using routeToLeader? Would it not make sense to make this use the client setting, as it is a read/write transaction?
spanner/client.go
Outdated
| // need to be routed to the leader region. | ||
| // | ||
| // Default: true | ||
| RouteToLeader bool |
There was a problem hiding this comment.
I think that we need to invert this to DisableRouteToLeader with a default false value. The problem now is that anyone who is currently using NewClientWithConfig(ClientConfig{ .... }) will create a config with RouteToLeader=false, unless they change their code after this change. We want this option to be enabled by default, but in the current setup, it won't be for anyone who does not use the config-less NewClient(...) method.
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
olavloite
reviewed
Mar 3, 2023
spanner/transaction.go
Outdated
| @@ -1676,7 +1681,7 @@ func (t *writeOnlyTransaction) applyAtLeastOnce(ctx context.Context, ms ...*Muta | |||
| return ToSpannerError(err) | |||
| } | |||
| } | |||
| res, err := sh.getClient().Commit(contextWithOutgoingMetadata(ctx, sh.getMetadata()), &sppb.CommitRequest{ | |||
| res, err := sh.getClient().Commit(contextWithOutgoingMetadata(ctx, sh.getMetadata(), true), &sppb.CommitRequest{ | |||
There was a problem hiding this comment.
Shouldn't this just use the client setting for disableRouteToLeader?
If not: It is a read/write transaction, so shouldn't the default then be false?
olavloite
approved these changes
Mar 3, 2023
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
rahul2393
added
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header is added to support leader-aware-routing feature, which aims at reducing cross-regional latency for RW/PDML transactions in a multi-region instance.