Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spanner/spansql): fix SQL for CREATE CHANGE STREAM TableName; case #7514

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

nktks
Copy link
Contributor

@nktks nktks commented Mar 6, 2023

This PR fixes CreateChangeStream's SQL() outputs for the case parsed CREATE CHANGE STREAM TableName;.

Reproduce Code:
main.go

package main

import (
	"fmt"

	"cloud.google.com/go/spanner/spansql"
)

func main() {
	fmt.Printf(spansql.CreateChangeStream{
		Name: "csname",
	}.SQL())
}

expected

CREATE CHANGE STREAM csname

actual

go run main.go
CREATE CHANGE STREAM csname FOR

@nktks nktks requested review from a team as code owners March 6, 2023 15:41
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the Spanner API. labels Mar 6, 2023
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 7, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 7, 2023
@rahul2393 rahul2393 merged commit fc5fd86 into googleapis:main Mar 7, 2023
@nktks nktks deleted the fix/spansql-cs-sql branch March 7, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants