feat(datastore): EntityFilter for AND/OR queries #7589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
telpirion
reviewed
Mar 20, 2023
datastore/query.go
Outdated
| Filters []EntityFilter | ||
| } | ||
|
|
||
| func (OR) isCompositeFilter() {} |
There was a problem hiding this comment.
suggestion: it looks like this method is only used to satisfy the CompositeFilter interface above. Same with AND below. Seems to me that you should be able to have both OR and AND structs fulfill the same interface without creating a dummy method. Try to remove isCompositeFilter().
There was a problem hiding this comment.
On removing, I see error:
cannot use &OR{…} (value of type *OR) as CompositeFilter value in struct literal: *OR does not implement CompositeFilter (missing method isCompositeFilter)
| return nil, errors.New("datastore: empty query filter field name") | ||
| } | ||
| v, err := interfaceToProto(reflect.ValueOf(qf.Value).Interface(), false) | ||
| pbFilter, err := qf.toProto() |
There was a problem hiding this comment.
praise: Nice refactor here!
enocom
reviewed
Mar 20, 2023
|
@bhshkh When you're ready for another round of reviews, just "Re-Request Review" on the side panel above and I'll take a look. |
enocom
approved these changes
Mar 27, 2023
codyoss
requested changes
Mar 28, 2023
codyoss
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new method 'FilterEntity' to Query which can be used to construct composite queries.
Adding the following new structs to be used with FilterEntity