fix(firestore): Replace usage of transform with update_transform in batch write #7864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xl
enocom
approved these changes
May 5, 2023
| @@ -1721,6 +1721,19 @@ func TestIntegration_ColGroupRefPartitionsLarge(t *testing.T) { | |||
| t.Errorf("Unexpected number of documents across partitions: got %d, want %d", got, want) | |||
| } | |||
| } | |||
| func TestIntegration_BulkWriter_Set(t *testing.T) { | |||
There was a problem hiding this comment.
A little comment above this test to explain what it's doing might be nice here.
kolea2
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing all usages of transforms with update_transforms will enable writes with field transforms to be performed in a single write.
This is important for BulkWriter to ensure that writes with field transforms do not have to be split into separate batches.
This will resolve #7636