feat(spanner): add integration tests for Bit Reversed Sequences #7924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
product-auto-label
bot
added
size: l
product-auto-label
bot
added
the
stale: old
product-auto-label
bot
added
stale: extraold
rahul2393
force-pushed
the
bit_reverse_sequence
branch
from
f193d5a
to
59ed527
Compare
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
harshachinta
reviewed
Aug 2, 2023
harshachinta
reviewed
Aug 2, 2023
harshachinta
reviewed
Aug 2, 2023
|
|
||
| } | ||
| if newCounter < counter { | ||
| return errors.New("expected c3 >= c2 >= c1") |
There was a problem hiding this comment.
Can we tell here that c1, c2, c3 are different states of counters. Currently it is bit hard to understand directly.
harshachinta
reviewed
Aug 2, 2023
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
harshachinta
reviewed
Aug 3, 2023
rahul2393
force-pushed
the
bit_reverse_sequence
branch
from
1c42cd9
to
fb67ec3
Compare
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
harshachinta
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.