Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datastore): Change aggregation result to return generic value #8167

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

bhshkh
Copy link
Contributor

@bhshkh bhshkh commented Jun 22, 2023

Partially reverting the change made in #7803 as it is a breaking change. The code that uses AggregationResult expected interface datatype in the map value but now concrete data types are being returned and break the code.

@bhshkh bhshkh requested review from a team as code owners June 22, 2023 19:10
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jun 22, 2023
@bhshkh bhshkh requested a review from enocom June 22, 2023 19:10
@product-auto-label product-auto-label bot added the api: datastore Issues related to the Datastore API. label Jun 22, 2023
@bhshkh bhshkh enabled auto-merge (squash) June 22, 2023 19:18
@bhshkh bhshkh merged commit 9d3d17b into googleapis:main Jun 22, 2023
8 checks passed
@bhshkh bhshkh deleted the revert-partial-pull-7803 branch June 22, 2023 22:42
@marwansalem
Copy link

hello, how can I use the result of an aggregation query? Can you point me towards the documentation?

@bhshkh
Copy link
Contributor Author

bhshkh commented Jul 18, 2023

hello, how can I use the result of an aggregation query? Can you point me towards the documentation?

#7800 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants