Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datastore): Return error from RunAggregationQuery #8222

Merged
merged 4 commits into from
Jul 6, 2023
Merged

fix(datastore): Return error from RunAggregationQuery #8222

merged 4 commits into from
Jul 6, 2023

Conversation

bhshkh
Copy link
Contributor

@bhshkh bhshkh commented Jul 6, 2023

  • Return error from RunAggregationQuery invocation
  • Add RunAggregationQuery integration tests

@bhshkh bhshkh requested review from a team as code owners July 6, 2023 18:10
@bhshkh bhshkh enabled auto-merge (squash) July 6, 2023 18:10
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: datastore Issues related to the Datastore API. labels Jul 6, 2023
@bhshkh bhshkh requested a review from enocom July 6, 2023 18:11
@bhshkh bhshkh mentioned this pull request Jul 6, 2023
Merged
@bhshkh bhshkh linked an issue Jul 6, 2023 that may be closed by this pull request
datastore: aggregation query panic with gte filter #8181
Closed
@bhshkh bhshkh added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jul 6, 2023
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 6, 2023
@bhshkh bhshkh merged commit a9b67cf into googleapis:main Jul 6, 2023
8 checks passed
@release-please release-please bot mentioned this pull request Jul 6, 2023
Merged
@bhshkh bhshkh deleted the issue-8181 branch July 18, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enocom enocom enocom approved these changes

@kolea2 kolea2 kolea2 approved these changes

Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datastore: aggregation query panic with gte filter
4 participants
@bhshkh @enocom @kolea2 @kokoro-team