Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner/spansql): add support for IF NOT EXISTS and IF EXISTS clause #8245

Merged
merged 8 commits into from Jul 20, 2023
Merged

feat(spanner/spansql): add support for IF NOT EXISTS and IF EXISTS clause #8245

merged 8 commits into from Jul 20, 2023

Conversation

toga4
Copy link
Contributor

@toga4 toga4 commented Jul 11, 2023

Resolves #8236

This PR adds support for following DDL syntax.

CREATE TABLE IF NOT EXISTS tname ...
CREATE INDEX IF NOT EXISTS iname ...
ALTER TABLE ADD COLUMN IF NOT EXISTS cname ...
DROP TABLE IF EXISTS tname
DROP INDEX IF EXISTS iname

@toga4 toga4 requested review from a team as code owners July 11, 2023 12:23
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the Spanner API. labels Jul 11, 2023
@toga4 toga4 changed the title feat(spanner): add support for IF NOT EXISTS and IF EXISTS clause feat(spanner/spansql): add support for IF NOT EXISTS and IF EXISTS clause Jul 16, 2023
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 17, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 17, 2023
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 19, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 19, 2023
@rahul2393 rahul2393 enabled auto-merge (squash) July 19, 2023 05:00
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 19, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 19, 2023
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 19, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2023
@rahul2393 rahul2393 merged commit 96840ab into googleapis:main Jul 20, 2023
8 checks passed
@release-please release-please bot mentioned this pull request Jul 20, 2023
Merged
@toga4 toga4 deleted the if-exists branch July 20, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahul2393 rahul2393 rahul2393 approved these changes

@marcusthelin marcusthelin marcusthelin approved these changes

@harshachinta harshachinta harshachinta approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spanner/spansql: support IF NOT EXISTS in DDL parsing
5 participants
@toga4 @rahul2393 @marcusthelin @harshachinta @kokoro-team