Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bigquery): field descriptor proto name should not be lowercase #8495

Merged
merged 2 commits into from Aug 29, 2023

Conversation

alvarowolfx
Copy link
Contributor

When converting protobufs back and forth to JSON, the protojson package handles conversion to lowercase camelcase, accordingly to the docs:

Resolves #8470

@alvarowolfx alvarowolfx requested review from a team as code owners August 25, 2023 21:50
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the BigQuery API. labels Aug 25, 2023
@alvarowolfx alvarowolfx merged commit 4287e4b into googleapis:main Aug 29, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloud.google.com/go/bigquery/storage/managedwriter/adapt: Marshalling fails if upper case present in JSON keys
2 participants