fix(storage): do not inhibit the dead code elimination. #8543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
|
Hi there! Does anybody look at PRs in this repo? @codyoss? @jadekler? Please do have a look at the patch, or assign it to a person who reviews changes in /storage. |
|
Hey @dominiquelefevre, this repo is monitored and we do accept PRs. That being said we may not always get to them immediately so please be patient with us. Also, we encourage all PRs to start with an issue first for discussion and triage to see if it is a change we are willing to make -- it saves both parties time in the long run. I encourage to to please open a corresponding issue to this PR. Thanks. |
product-auto-label
bot
added
the
stale: old
When the go compiler encounters a call to MethodByName(), it
assumes that every method of every reachable type can be accessed,
and nothing may be eliminated.
Go 1.22 has gained support for calls like MethodByName("Foobar").
If the argument to MethodByName() is a compile-time constant, then
the compiler no longer disables the DCE, and only keeps methods
named Foobar.
Rewrite setConditionField() so that MethodByName() is only called with
compile-time constants. This way importing cloud.google.com/go/storage
will not inhibit the DCE.
|
ping @BrennaEpp |
|
Hey, anybody out here? @BrennaEpp? |
product-auto-label
bot
added
stale: extraold
BrennaEpp
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
BrennaEpp
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the go compiler encounters a call to MethodByName(), it assumes that every method of every reachable type can be accessed, and nothing may be eliminated.
Go 1.22 has gained support for calls like MethodByName("Foobar"). If the argument to MethodByName() is a compile-time constant, then the compiler no longer disables the DCE, and only keeps methods named Foobar.
Rewrite setConditionField() so that MethodByName() is only called with compile-time constants. This way importing cloud.google.com/go/storage will not inhibit the DCE.
Fixes #8745