Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner): BatchWrite #8652

Merged
merged 10 commits into from Oct 27, 2023
Merged

feat(spanner): BatchWrite #8652

merged 10 commits into from Oct 27, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 5, 2023 •
edited by ghost

Implementation for BatchWrite API.

@ghost ghost requested review from a team as code owners October 5, 2023 18:59
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the Spanner API. labels Oct 5, 2023
@harshachinta harshachinta self-requested a review October 12, 2023 09:59
@ghost
Copy link
Author

ghost commented Oct 17, 2023

@harshachinta - Can you please review?

@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2023
harshachinta
harshachinta reviewed Oct 19, 2023
View reviewed changes
spanner/mutation.go Outdated Show resolved Hide resolved
@harshachinta
Update comment
94a921a 
Co-authored-by: Sri Harsha CH <57220027+harshachinta@users.noreply.github.com>
@ghost ghost requested a review from harshachinta October 20, 2023 06:59
harshachinta
harshachinta reviewed Oct 23, 2023
View reviewed changes
spanner/client.go Outdated Show resolved Hide resolved
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2023
harshachinta
harshachinta approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@harshachinta harshachinta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@harshachinta harshachinta added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 26, 2023
@harshachinta harshachinta removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 27, 2023
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 27, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 27, 2023
@harshachinta harshachinta merged commit 507d232 into googleapis:main Oct 27, 2023
10 checks passed
@release-please release-please bot mentioned this pull request Oct 27, 2023
Merged
@ghost ghost deleted the feat-batch-write branch October 27, 2023 10:36
bhshkh pushed a commit that referenced this pull request Nov 3, 2023
@harshachinta @bhshkh
feat(spanner): BatchWrite (#8652)
7547808 
* feat(spanner): BatchWrite

* vet: apply recommendations

* Update comment

Co-authored-by: Sri Harsha CH <57220027+harshachinta@users.noreply.github.com>

* Add BatchWriteOptions

* remove redundant int conversion

---------

Co-authored-by: Sri Harsha CH <57220027+harshachinta@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rahul2393 @harshachinta @kokoro-team @sunny1612