Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): add Credentials.UniverseDomain() #8654

Merged
merged 3 commits into from
Oct 5, 2023
Merged

feat(auth): add Credentials.UniverseDomain() #8654

merged 3 commits into from
Oct 5, 2023

Conversation

quartzmo
Copy link
Member

@quartzmo quartzmo commented Oct 5, 2023

Read and expose universe_domain from self-signed service account JSON

Equivalent to:

@quartzmo
feat(auth): add Credentials.UniverseDomain()
51265c0 
Read and expose universe_domain from self-signed service account JSON
@quartzmo quartzmo requested a review from a team as a code owner October 5, 2023 20:54
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Oct 5, 2023
codyoss
codyoss approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quartzmo quartzmo merged commit af0aa1e into googleapis:main Oct 5, 2023
9 checks passed
@quartzmo quartzmo deleted the auth-detect-universe-domain branch October 5, 2023 21:31
@release-please release-please bot mentioned this pull request Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@quartzmo @codyoss