Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub: TestIntegration_OrderedKeys_JSON failed #8702

Closed
flaky-bot bot opened this issue Oct 12, 2023 · 3 comments · Fixed by #8765
Closed

pubsub: TestIntegration_OrderedKeys_JSON failed #8702

flaky-bot bot opened this issue Oct 12, 2023 · 3 comments · Fixed by #8765
Assignees
@hongalex
Labels
api: pubsub Issues related to the Pub/Sub API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Oct 12, 2023

Note: #8564 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.

commit: 4284639
buildURL: Build Status, Sponge
status: failed

Test output
    integration_test.go:1309: timed out after 5m waiting for all messages to be received
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 12, 2023
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Oct 12, 2023
@flaky-bot
Copy link
Author

flaky-bot bot commented Oct 12, 2023

Test passed for commit 9c502c2 (Build Status, Sponge)! Closing this issue.

@flaky-bot flaky-bot bot closed this as completed Oct 12, 2023
@hongalex
Copy link
Member

Noting this is separate from previous fix. If this opens again, I'll add a retry guard around the ordering key tests

@flaky-bot flaky-bot bot mentioned this issue Oct 16, 2023
Closed
@flaky-bot flaky-bot bot reopened this Oct 19, 2023
@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Oct 19, 2023
@flaky-bot
Copy link
Author

flaky-bot bot commented Oct 19, 2023

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.

commit: f8ba0b9
buildURL: Build Status, Sponge
status: failed

Test output
    integration_test.go:1309: timed out after 5m waiting for all messages to be received

@hongalex hongalex mentioned this issue Oct 24, 2023
Merged
@hongalex hongalex added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Oct 27, 2023
@flaky-bot flaky-bot bot mentioned this issue Nov 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hongalex hongalex

Labels
api: pubsub Issues related to the Pub/Sub API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(pubsub): add retry guard to ordering key test hongalex/google-cloud-go
1 participant
@hongalex